Add support for custom authorization message #578
Conversation
CHANGELOG.md
Outdated
|
|
||
|
|
||
| 2020-01-19, 4.0.0 | ||
| ----------------- |
There was a problem hiding this comment.
Please remove these lines, as the next release date isn't decided yet!
There was a problem hiding this comment.
Sure will do. I haven't added this initially, but saw in the PR checklist it was required to amend CHANGELOG.md and wasn't sure what exactly to add. Are you happy to remove the whole entry I've added?
There was a problem hiding this comment.
No, please keep the changelog (it's a "change log", after all 😜) but only remove the lines I covered in github!
There was a problem hiding this comment.
@mfn Right, should be ok now I think :)
src/Support/Field.php
Outdated
| /** | ||
| * @return string | ||
| */ |
There was a problem hiding this comment.
Please remove the phpdoc, doesn't "add" anything here, thanks!
tests/Unit/GraphQLQueryTest.php
Outdated
| /** | ||
| * Test query with authorize. | ||
| */ | ||
| public function testQueryAndReturnResultWithAuthorizeMessage(): void |
There was a problem hiding this comment.
| public function testQueryAndReturnResultWithAuthorizeMessage(): void | |
| public function testQueryAndReturnResultWithCustomAuthorizeMessage(): void |
What do you think about this suggestion?
|
Thanks for the feedback @mfn , I've updated my PR. |
|
https://github.com/rebing/graphql-laravel/releases/tag/5.0.0 has been released which includes this! |
Summary
Currently it is not possible to override the authorization message in case the authorization message returns false.
Type of change
Checklist
composer fix-style