-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add morph type to returned models #503
Conversation
af79f3a
to
bd00c42
Compare
Thanks for asking, I haven't yet disclosed my thoughts on this. Basically I'm following https://laravel.com/docs/master/releases That's why I also removed tests for 5.6 and 5.7 without much discussion via #488 I basically took the easy way out: I just stick to the LTS table. Once a version is beyond security fixes it can be removed on first sign of troubles. |
Ok will make a fix for laravel 5.5 |
how do I actually run this for Laravel 5.5 locally? I tried removing all other versions from illuminate/contracts, illuminate/support in the composer.json, but gets alot of composer errors. |
I believe from
|
Thanks, will try
Hent Outlook til iOS<https://aka.ms/o0ukef>
…________________________________
Fra: Markus Podar <[email protected]>
Sendt: Monday, October 28, 2019 12:24:53 PM
Til: rebing/graphql-laravel <[email protected]>
Cc: Christian <[email protected]>; Author <[email protected]>
Emne: Re: [rebing/graphql-laravel] add morph type to returned models (#503)
I believe from .travis.yml, these lines from the install section are relevant:
composer require "illuminate/support:${LARAVEL}" --no-interaction --no-update
composer install --prefer-dist --no-interaction --no-suggest
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#503?email_source=notifications&email_token=AAXPDYQMTHTPLYWM3G3G73TQQ3DYLA5CNFSM4JFAWYQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECMRM2I#issuecomment-546903657>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAXPDYSTE5775SCJAXGVGZDQQ3DYLANCNFSM4JFAWYQA>.
|
280ad5d
to
fbcf9ab
Compare
tests/Database/SelectFields/RelationshipsTest/MorphRelationshipTest.php
Outdated
Show resolved
Hide resolved
tests/Database/SelectFields/RelationshipsTest/MorphRelationshipTest.php
Outdated
Show resolved
Hide resolved
de290e2
to
3cf3c8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much 🤗
when you retrieve the morphed models in your query resolver the type is missing so don't know what type it is
Are we going to continue to support 5.5? can see the tests are failing for that version