Separate Larastan config #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
reviewed
Aug 16, 2019
| @@ -1,23 +1,13 @@ | |||
| includes: | |||
| - larastan.neon | |||
There was a problem hiding this comment.
I'm wondering, can't we just reference the config shipped with larastan that way? 🤷♀️
There was a problem hiding this comment.
Feel free to experiment with it. Actually I promote phpstan, I'm not a graphql user.
There was a problem hiding this comment.
vendor/nunomaduro/larastan/extension.neon
There was a problem hiding this comment.
I do not know how to un-ignore errors.
There was a problem hiding this comment.
I do not know how to un-ignore errors.
Ahh. I guess that what the reason in the first place why I assimilated it.
mfn
approved these changes
Aug 16, 2019
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mfn What do you think?