Port over Folklore config headers and json_encoding_options #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebing
approved these changes
Jun 3, 2019
mfn
force-pushed
the
mfn-json
branch
2 times, most recently
from
9819a47 to
2ec267b
Compare
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
============================================
+ Coverage 51.78% 51.96% +0.17%
Complexity 321 321
============================================
Files 31 31
Lines 1091 1095 +4
============================================
+ Hits 565 569 +4
Misses 526 526
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
The plan is to also back-port this to the v1 and cut a new release (cherry-picking the first commit in here).