Bump thecodingmachine/safe to v3 #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good move, let's do it. Of course a bit more work is needed because of the phpstan upgrade :/ |
|
Nice to hear! Yeah, I just saw that. Didn't check it locally. Just ran the tests and thought I'll be good to go 🙈 |
|
phpstan never lets you easy off the hook ;) |
|
I just noticed that 🙃 |
mfn
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
thecodingmachine/safeto v3, and all corresponding deps to their current version to avoid deprecation warnings in PHP 8.4.Removed the usage of
\Safe\sprintfin favor of puresprintf, becausesprintfdoesn't returnfalseon error as of PHP 8.0.Tested locally with PHP 8.3 and PHP 8.4 without issues.
Type of change:
Checklist:
composer fix-style