Add support for Laravel 11 #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid the hundreds of warnings about classes phpunit can't find, because they're in fact not test classes. E.g.: ``` There were 116 PHPUnit test runner warnings: 1) Class ExampleNestedValidationInputObject cannot be found in /Users/neo/src/swatio/tmp/mfn/graphql-laravel/tests/Unit/AliasArguments/Stubs/ExampleNestedValidationInputObject.php 2) Class ExampleType cannot be found in /Users/neo/src/swatio/tmp/mfn/graphql-laravel/tests/Unit/AliasArguments/Stubs/ExampleType.php … ```
To avoid composer version dependency conflicts
mfn
commented
Feb 18, 2024
| @@ -50,8 +50,8 @@ | |||
| "mockery/mockery": "^1.2", | |||
| "phpstan/phpstan": "1.10.40", | |||
| "larastan/larastan": "2.6.4", | |||
| "orchestra/testbench": "^7.0|^8.0", | |||
| "phpunit/phpunit": "^9", | |||
| "orchestra/testbench": "^7.0|^8.0|^9.0|^9.x-dev", | |||
There was a problem hiding this comment.
^9.0 isn't available yet, hence we also add ^9.x-dev, ought to be removed once 9 is out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the integration tests, I needed to use 11.x-dev for now
Type of change:
Checklist:
composer fix-style