Fix -[RLMApp baseURL] always being nil #8573
Conversation
tgoyne
force-pushed
the
tg/app-baseurl
branch
5 times, most recently
from
5106acf to
529d6a9
Compare
|
The sync tests now pass for me locally†. Thankfully everything broken iutside of baseURL was bugs in the tests and not bugs in the library. The sync jobs are now failing on CI because it's no longer silently ignoring errors when installing BaaS. AFAICT, installing BaaS has been broken ever since they added another private dep that Xcode Cloud doesn't have permission to access in Sept 2023, and the reason the sync tests got so much more reliable when we migrated to Xcode Cloud is that they've never actually been running. The SPM tests were failing to actually invoke setup_baas.rb at all; I fixed this and then re-disabled it because we want to at least be running the non-sync tests with asan/tsan. † Sometimes. Creating an app in BaaS fails ~5% of the time which means there's often at least one failure while running the full test suite. |
| @@ -22,8 +22,10 @@ import RealmSwift | |||
| @available(iOS 13.0, macOS 10.15, tvOS 13.0, watchOS 6.0, *) | |||
| class SwiftUITests: XCTestCase { | |||
| var realm: Realm! | |||
| @MainActor | |||
There was a problem hiding this comment.
Any reason we are forcing this to be in the main actor (thread)
There was a problem hiding this comment.
All of the UI test stuff is @MainActor and produces warnings about cross-actor access if used from unconfined contexts.
| @@ -16,10 +16,11 @@ install_dependencies() { | |||
| brew install swiftlint | |||
| elif [[ "$CI_WORKFLOW" == "cocoapods"* ]]; then | |||
| install_ruby | |||
| elif [[ "$CI_WORKFLOW" == "objectserver"* ]] || [[ "$target" == "swiftpm"* ]]; then | |||
| elif [[ "$CI_WORKFLOW" == "sync"* ]]; then | |||
| # elif [[ "$CI_WORKFLOW" == "sync"* ]] || [[ "$CI_WORKFLOW" == "swiftpm"* ]]; then | |||
There was a problem hiding this comment.
Are we not running the sync tests in SPM?
There was a problem hiding this comment.
We're not running the sync tests anywhere, and trying and failing to install baas now results in the non-sync spm tests not running.
It turns out that our sync tests have been silently failing to run on CI for quite a while.
Hopefully this is the only broken thing.There's a bunch of failing things.I had to rewrite the baseUrl tests because they were not even remotely close to working.