RCORE-2135 Make AsyncOpenTask wait until all pending subscriptions finish bootstrapping

[danieltabacaru]

What, How & Why?

Opening an FLX realm asynchronously may not wait to download all data. We changed it so the asynchronous task now waits until all subscriptions finish bootstrapping.

Fixes #7720.

☑️ ToDos

• 📝 Changelog update
• 🚦 Tests (or not relevant)
• [ ] C-API, if public C++ API changed
• [ ] bindgen/spec.yml, if public C++ API changed

[coveralls-official]

Pull Request Test Coverage Report for Build daniel.tabacaru_849

Details

• 70 of 73 (95.89%) changed or added relevant lines in 2 files are covered.
• 129 unchanged lines in 17 files lost coverage.
• Overall coverage decreased (-0.05%) to 90.94%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/realm/object-store/sync/async_open_task.cpp	12	15	80.0%

Files with Coverage Reduction	New Missed Lines	%
src/realm/sort_descriptor.cpp	1	94.06%
src/realm/sync/instructions.hpp	1	76.03%
src/realm/sync/network/websocket.cpp	1	71.79%
src/realm/util/serializer.cpp	1	90.43%
test/test_dictionary.cpp	1	99.83%
src/realm/query_expression.cpp	2	86.62%
src/realm/sync/instruction_applier.cpp	3	68.01%
src/realm/sync/network/http.hpp	3	82.27%
src/realm/table.cpp	3	90.37%
src/realm/alloc_slab.cpp	4	90.56%

Totals
Change from base Build 2402:	-0.05%
Covered Lines:	214531
Relevant Lines:	235904

---

💛 - Coveralls

[nicola-cab]

it looks good in regard to the new logic, but I think we should remove the rerun on launch flag, don't we?

[nicola-cab]

So it seems we are going to ignore the rerun_on_launch flag. Don't we have to remove it from the configuration.
bool rerun_init_subscription_on_open{false}; ... also isn't this going to be a breaking change for the SDKs? Am I wrong?

[danieltabacaru]

So it seems we are going to ignore the rerun_on_launch flag.

Not entirely. We do use it in the RealmCoordinator to decide if the subscription initializer callback is invoked or not.

[nicola-cab]

OK, I tested it and it looks good! Approved. But we have an address sanitizer issue:
==1892==ERROR: AddressSanitizer: access-violation on unknown address 0x0066b552a870 (pc 0x0066b552a870 bp 0x000000000000 sp 0x0066b5528128 T0)

[danieltabacaru]

OK, I tested it and it looks good! Approved. But we have an address sanitizer issue: ==1892==ERROR: AddressSanitizer: access-violation on unknown address 0x0066b552a870 (pc 0x0066b552a870 bp 0x000000000000 sp 0x0066b5528128 T0)

yeah, I am looking into it. All the other tasks fail because the realm file is accessed from a different thread.