Build: update all build.tools and add latest versions
#11386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Jun 6, 2024
humitos
added a commit
that referenced
this pull request
Jun 11, 2024
CircleCI is failing when building `build.tools` because Ruby 3.3.2 is not yet available in the `asdf` version we have in our Ubuntu Docker image. Updating the version of `asdf` and its plugins allows us to pre-compile these versions when running the CircleCI job. This is required by #11386 Once this PR gets merged, we need to restart the CircleCI job. https://app.circleci.com/pipelines/github/readthedocs/readthedocs-docker-images/294/workflows/3764492d-0fd4-44a3-bb0c-fccb696dc130/jobs/514
humitos
added a commit
that referenced
this pull request
Jun 11, 2024
…11401) CircleCI is failing when building `build.tools` because Ruby 3.3.2 is not yet available in the `asdf` version we have in our Ubuntu Docker image. Updating the version of `asdf` and its plugins allows us to pre-compile these versions when running the CircleCI job. This is required by #11386 Once this PR gets merged, we need to restart the CircleCI job. https://app.circleci.com/pipelines/github/readthedocs/readthedocs-docker-images/294/workflows/3764492d-0fd4-44a3-bb0c-fccb696dc130/jobs/514
stsewd
approved these changes
Jun 11, 2024
|
@humitos many thanks for that! I just tried it with golang 1.22 but it was too soon. Do you have a rough ETA on this for public consumption? Just trying to gauge if I wait a few hours or a few days. |
|
@simondeziel we are going to deploy these changes next Tuesday. I will suggest you to come back and try this next Wednesday to be sure it will work. |
|
@humitos excellent, thanks again |
humitos
added a commit
that referenced
this pull request
Nov 14, 2024
Ref: #11386 and #10808 Not sure if I missed anything. Looking into `scripts/compile_version_upload.sh`, I don't know if the selected `virtualenv` version works with 3.13 (in fact I don't know if that package has officially supported 3.13 yet). I initially wanted to raise an issue to support Node.js 22, but then I got curious and thought I could help speed up the process. Feel free to pick it up from here if there are other areas that need to be updated e.g. https://github.com/readthedocs/readthedocs-docker-images 🙂 Closes #11671 <!-- readthedocs-preview docs start --> --- :books: Documentation previews :books: - User's documentation (`docs`): https://docs--11742.org.readthedocs.build/en/11742/ <!-- readthedocs-preview docs end --> <!-- readthedocs-preview dev start --> - Developer's documentation (`dev`): https://dev--11742.org.readthedocs.build/en/11742/ <!-- readthedocs-preview dev end --> --------- Co-authored-by: Manuel Kaufmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches readthedocs/readthedocs-docker-images#205
Closes #11350
📚 Documentation previews 📚
docs): https://docs--11386.org.readthedocs.build/en/11386/dev): https://dev--11386.org.readthedocs.build/en/11386/