[0.80] Fix broken focus behavior for TextInput in older Android versions (< 9)

[joevilches]

Target Branch

0.80

Link to commit or PR to be picked

facebook/react-native#51462

Description

facebook/react-native#48547 introduced a bug on older Android versions (< 9). The nature of this bug is described in facebook/react-native#51072. The TLDR is that the first TextInput's would not be able to be blurred (use focus) once they gained focus. This is because of Android behavior that attempts to focus the first focusable View in the hierarchy after clearing focus. This is supposed to only happen not in touch mode (using hardware keyboard), but it happens in touch mode nevertheless. This PR uncovered that issue.

The PR to be picked is the fix.

I am a bit confused about how this pick works actually:
* Do I need to create a separate pick for 0.80? (fix slated for 0.81)
* The nature of this file surely changed a lot between now and then, is there a merge conflict to resolve? If so am I needed to ensure its accurate?

EDIT: see @cortinico's response below

[react-native-bot]

Thank you for opening a new pick-request for React Native.
Those are the criterias we follow when accepting/rejecting a pick request (source).

If your pick does not satisfy the criteria below, please close it as it will not be considered.

✅ Which pick requests we accept

1. ✅ Fixes for regressions to core APIs. Examples:
   • A core component is behaving differently between version 0.X and 0.X-1
   • The TurboModule.getEnforcing function is throwing an assertion error which is not expected.
2. ✅ Fixes to bugs in the core React Native’s experience. Examples:
   • Breakpoints in React Native DevTools not working correctly in the debugger
   • Fast Refresh not working as expected
   • Metro bundler not starting properly or ignoring the configuration file
   • Buttons that are not clickable
3. ✅ Fixes to APIs used by 3P libraries and Out-of-tree platforms. Examples:
   • An API that is used by react-native-macos is not behaving as expected or regressing
4. ✅ Bump of patch version of dependencies. Example:
   • Bump Gradle from 8.11.0 to 8.11.1
5. ✅ Fixes for Low/High Security Vulnerability. Example:
   • Bump Gradle from 8.11.0 to 8.12.0 if there is a security vulnerability in 8.11 and there is no version 8.11.x which would contain the same fix.
6. ✅ Fixes and reverts of accidental breaking changes. Example:
   • Reverting or fix-forwarding a migration to Kotlin of a file (say ReactRootView.java ) if that is causing a breaking change for the whole React Native ecosystem.
7. ✅ Performance improvements picks. Examples:
   • Fixing unnecessary rendering on FlatList.
8. ✅ Any pick if the release is still in RC0 (after RC1 the previous listed criteria applies)

❌ Which pick requests we don’t accept

9. ❌ Any pick that will introduce a breaking change after RC1. Example:
   • A bugfix that contains a refactoring, resulting in changes to the public API of a class
10. ❌ Any pick that introduces a new feature after RC1. Example:
    • A commit that introduces a new API or a specific feature for a component.
11. ❌ Bump of major/minor version of dependencies. Example:
    • Bump Gradle from 8.11.0 to 8.12.0
    • Bump Gradle from 8.11.0 to 9.0.0
12. ❌Bump of a dependency to a non stable/alpha/beta version. Example:
    • Bump Gradle from 8.11.0 to 8.11.1-beta.1
13. ❌Any pick that introduces changes to the testing infrastructure of React Native after RC1. Examples:
    • Changes to the GitHub Actions workflows to optimize it, even if they’re on main.
    • Changes to the logic used to publish packages to NPM or Maven Central
14. ❌ Pick composed by various commits that has several merge conflicts
    • If your pick is too complicated to apply on the release branch, we’re going to reject it.
15. ❌ Any other non-critical improvement that landed on main.
    • In general those will ship in the following version unless they fit in one of the criteria above
16. ❌ Any other pick which is considered “small enough” to make it into a release.
    • If your pick is a one liner but is a ‘nice to have’, we won’t be picking it, as it has the risk of destabilizing the release and further delaying the release.

ℹ️ What makes for a good pick

In order for your pick to be considered, please do the following:

• ℹ️ Have a pick that contains only one commit from main, or only one PR against the release branch.
• ℹ️ Have a clear explanation of why your pick should be considered, ideally referencing one of the criteria above.
• ℹ️ Target only one minor version of React Native (e.g. [0.76]). If you want your pick to be applied to more versions, please open different picks.

[cortinico]

Hey @joevilches
Thanks for opening this pick.

There are a number of things we'll need to do/clarify before we can merge this:

1. You specified facebook/react-native@1e6dec0 but I believe the SHA you linked is wrong.
   It should be insteadl facebook/react-native@d07b2a9 Do you confirm?

2. There are a lot of conflicts on both the 0.80 and the 0.79 release branch. You can verify them by yourself by doing:

git clone git@github.com:facebook/react-native.git
cd react-native
git checkout 0.80-stable
git cherry-pick d07b2a9d992c7240006d7d3607a109215deff5c6

You can see them listed here:

They're mostly feature flags changes, so I would suggest you just run yarn featureflags --update in your branch to fix them.

However there are conflicts on ReactEditText that you would need to solve manually.

3. The 0.79 pick is going to be even harder because we converted ReactEditText from Java to Kotlin, but in 0.79 it's still in Java. Let's focus on the 0.80 pick for now and we'll think about 0.79 afterwards.

4. The best would be if you could fix the conflicts against the 0.80 branch, and send a Pull request from your branch against the https://github.com/facebook/react-native/tree/0.80-stable branch of React Native. @hezi and @fabriziocucci can then take care of it for the upcoming RC.

[joevilches]

@cortinico Thanks for the detailed instructions! I made the PR into 0.80-stable here: facebook/react-native#51462

[fabriziocucci]

PR merged.