[0.76] Fix cursor moving while typing quickly and autocorrection triggered in controlled single line TextInput on iOS (New Arch)

[mhoran]

Target Branch(es)

0.76

Link to commit or PR to be picked

facebook/react-native#46970
facebook/react-native@557e344
and facebook/react-native#47269.

Description

A long standing bug with TextInput has been fixed in New Arch in the aforementioned PR. The bug manifested as many different issues, requiring various workarounds. As of 0.76, at least one of these workarounds no longer works in New Arch (facebook/react-native#29572 (comment)).

Related issues:
facebook/react-native#29572
facebook/react-native#42792
facebook/react-native#27693
... and likely others.

[mhoran]

Unfortunately after some testing it seems that the aforementioned issues are not fixed by this patch, though it is still likely worth pulling in.

[cipolleschi]

@mhoran could you provide a repro with this template to show that it is not fixed?

[cipolleschi]

We might also need facebook/react-native@557e344

[blakef]

Holding on this for 0.76.1, waiting for a reproducer.

[mhoran]

Here is a repro with both patches applied: https://github.com/mhoran/new-arch-autocorrect-repro.

I am in fact able to reproduce all of the issues that were reportedly fixed with facebook/react-native#46970 -- so perhaps the fix is incomplete.

1. If I type incredibly fast with a hardware keyboard in a simulator, I see the cursor move incorrectly (Discourage using controlled inputs in React Native because they are broken facebook/react-native-website#4247).
2. Issues 27693 and 42792, which were both closed when Fix cursor moving while typing quickly and autocorrection triggered in controlled single line TextInput on iOS (New Arch) facebook/react-native#46970 was merged, can be reproduced (type a word, then space twice, and "." will not be entered.)
3. The undo button flickers when typing and otherwise does not work (iOS TextInput - text undo/redo doesn't work if value, defaultValue, or onChange is set facebook/react-native#29572).

Perhaps there's another missing patch?

[NickGerleman]

Let me take a look at these, to see if something might have broke since the initial iteration of the change and what was merged. I'm also seeing this not fixed, which wasn't the case earlier.

Once that is settled, I do think we should pick the collection of changes. I was holding out until this week, since as of this Wednesday, the change will have been in major production apps for about a week.

[NickGerleman]

@mhoran I think I tracked this down. Would you be able to try also applying the change in facebook/react-native#47269 ?

The gist is that, the controlled component I used in testing accepted value as child instead of via value prop, and the case of accepting by value may have a separate bug causing inequality.

[mhoran]

facebook/react-native#47269 works for me! All the issues mentioned in #595 (comment) are resolved with the three patches discussed:
facebook/react-native#46970
facebook/react-native@557e344
and facebook/react-native#47269.

Thanks for taking a look at this so quickly!