Skip to content
This repository was archived by the owner on Feb 25, 2020. It is now read-only.

[Web] More web support #88

Merged
merged 5 commits into from
Mar 7, 2019

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Feb 22, 2019

Why

Fix how navigation works (by default) in preparation for Expo web.

How

  • Make styles default to Material (same as RNWeb)
  • Fixed minor bug where Assets returned nothing -- this throws in error in when users attempt to preload assets
  • Fixed minor bug where null objects were being spread
  • Prevent the use of createKeyboardAwareNavigator on web

Related

#74
RNGH Web Support

@iamnader
Copy link

❤️

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Just one comment

};
}
},
default: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we also want to add shadows for web?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya this sounds good. let's do it in follow up pr

@brentvatne brentvatne merged commit 9126e29 into react-navigation:master Mar 7, 2019
@satya164 satya164 deleted the @evanbacon/web-support branch March 7, 2019 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants