Provide a way to disable React-Native console.log

[Andarius]

Introduction

When running in release mode, React-native will display info logs (as also mentioned in this issue: facebook/react-native#18584 and in this PR: facebook/react-native#30579 )

Details

For instance, using react-native-navigation, the following logs are displayed (because of Libraries/ReactNative/AppRegistry.js:186):

Running "main.Session" with {"initialProps":{"componentId":"Component1"},"rootTag":1301}

Causing them to appear in report logs like Bugsnag:

Discussion points

Since it seems accepted that the default behavior is that React Native is logging data via console.log and the recommended way to deal with it is to install a third-party package, I would like to propose the idea of setting a flag to be able to disable it.

Something like AppRegistry.disableLogs seems like a reasonable approach.

[kelset]

Sounds like, based on the conversation here facebook/react-native#30579, that the best way forward is for you to directly open the PR introducing the behaviour you are proposing :)

[Andarius]

Isn't better to discuss what is the best approach beforehand ? So that the PR has chances to be accepted / not closed without discussion ? (and that I don't spend time changing code that nobody wants to be changed haha)

[matt-oakes]

This shouldn't be something that's inside React Native at all. If you want to change the behaviour of console.log in your app, then you always have the option of overriding the global as shown in this StackOverflow answer.

[Andarius]

I'm not speaking about changing the console.log behavior. Just a "proper" way to disable it where I don't need it.
Let's say I want to do a console.log somewhere else that is meaningful to my app ?

My first concern is that this log appears out of nowhere, I had to grep my code base to find that it was RN that was doing the console.log.

[a-c-sreedhar-reddy]

A babel plugin can be used I guess. As mentioned here http://reactnative.dev/docs/performance#using-consolelog-statements

…

On Tue, 15 Dec 2020 at 15:11, Julien Brayere ***@***.***> wrote: I'm not speaking about changing the console.log behavior. Just a "proper" way to disable it where I don't need it. Let's say I want to do a console.log somewhere else that is meaningful to my app ? My first concern is that this log appears out of nowhere, I had to grep my code base to find that it was RN that was doing the console.log. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#308 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD2WBO6PIUPSYX6QPTC35RLSU4VNHANCNFSM4U367NHA> .

[Andarius]

@a-c-sreedhar-reddy then how can I do it I want other logs to be displayed but not the RN ones ?

[skaldo]

Hi @Andarius,
if logs visible in Bugsnag is the only issue you are experiencing, what about simply disabling the log breadcrumb type as described here?

If you want only to suppress all logs that do not come from your code, then I'm afraid, that you will need to write custom babel plugin that removes all console.x calls from node_modules only.

[Andarius]

That's why I'm asking for a solution to remove specifically the logs from react-native if we want to.
Again, what if I need the logs from other libs but not the RN ones ?

[phuongwd]

@Andarius Did you try this solution babel/minify#934 ?

it's working 💯 I noticed, the log message Bugsnag loaded can not remove.

module.exports = api => {
  const babelEnv = api.env();
  ...
  const plugins = [];
  if (babelEnv !== 'development') {
    plugins.push('transform-remove-console');
  }
  return {
    presets: ['module:metro-react-native-babel-preset'],
    plugins,
  };
};

[Andarius]

@phuongwd this will disable all console.log as mentioned above

[phuongwd]

@Andarius and this will disable the RN console.log
This log will not appear on Bugsnag

[Andarius]

@phuongwd this will remove all console.log or only the one from the react-native library ?

[phuongwd]

@Andarius this will remove all console.log and the log like this

[phuongwd]

@Andarius btw I have implemented the remove console.log as RN document, it was working.

But I saw console.log in redux-persist migrate method did not remove in production recently. See image, that's reason I updated as mentioned #308 (comment)