Skip to content

R CMD check WARNINGs due to license #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rrrlw opened this issue Oct 3, 2020 · 2 comments
Closed

R CMD check WARNINGs due to license #3

rrrlw opened this issue Oct 3, 2020 · 2 comments
Assignees

Comments

@rrrlw
Copy link
Contributor

rrrlw commented Oct 3, 2020

Previous DESCRIPTION versions list GPL (>=2) as the package license; currently, DESCRIPTION refers to the file LICENSE, which (I think) is usually reserved for non-standard licenses (the file itself contains GPL-3, a standard FOSS license).

This results in 2 WARNINGs in R CMD check --as-cran for c212 on my local machine with the following text:

* checking CRAN incoming feasibility ... WARNING
Change to non-FOSS package license.
New license:
  LICENSE
Old license:
  GPL (>= 2)
* checking DESCRIPTION meta-information ... WARNING
Non-standard license specification:
  LICENSE
Standardizable: FALSE

IMO, this could be fixed by switching the package license in DESCRIPTION to GPL-3; however, GPL-3 + file LICENSE could also be appropriate.

Can use this chapter from the R Packages book as a reference.

Part of this JOSS review.

@rrrlw rrrlw changed the title R CMD check WARNINGs due to non-FOSS license R CMD check WARNINGs due to license Oct 3, 2020
rcarragh added a commit that referenced this issue Oct 6, 2020
@rcarragh
Copy link
Owner

rcarragh commented Oct 6, 2020

I can replicate the error.
Some background as to why it happens: when the package was originally released to CRAN in 2017, I specified the licence as GPL (>=2) in the DESCRIPTION file. And it remanied as this up to until I submitted my paper to JOSS. As part of the pre-review process I was asked to include a LICENSE file. I couldn't find a suitable file for GPL >=2 (really multiple licences) so I included the GPL-3 file as the sucessor licence.

I can fix the issue by following your suggestion of:

License: GPL-3 + file LICENSE

in the DESCRIPTION file and I've added

Year: 2020
COPYRIGHT HOLDER: Raymond Carragher
Contact: [email protected]

to the LICENSE file after "END OF TERMS AND CONDITIONS"

This doesn't give me any warnings or notes when when I build the package with "check --as-cran".

Note: this will also affect the "Missing parts of GPL-3 #1" open issue.

@rrrlw
Copy link
Contributor Author

rrrlw commented Oct 21, 2020

You've described an appropriate fix, appreciate the context. Changes look great, thank you!

@rrrlw rrrlw closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants