Skip to content

feat(app): Add cron jobs to app chart #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 26, 2022
Merged

feat(app): Add cron jobs to app chart #62

merged 9 commits into from
Jul 26, 2022

Conversation

bsushmith
Copy link
Member

@bsushmith bsushmith commented Jun 28, 2022

Ties up with this guardian issue - raystack/guardian#191 to be able to run guardian jobs separately as cron jobs.

@bsushmith bsushmith marked this pull request as ready for review June 29, 2022 11:12
@rahmatrhd
Copy link
Member

is it possible to have this as part of stable/guardian only?
cc @AkarshSatija @rohilsurana @ravisuhag

@ravisuhag
Copy link
Member

@bsushmith Yes, let's make this part of the Guardian chart only. cc @rahmatrhd

@bsushmith bsushmith changed the title feat(guardian-jobs): Add guardian-jobs chart feat(app): Add cron jobs to app chart Jul 5, 2022
@bsushmith
Copy link
Member Author

@ravisuhag @rahmatrhd made the changes as part of the app chart itself. Felt it could be useful for other applications, so instead of just for guardian, added to app chart itself directly.

@ravisuhag
Copy link
Member

@rahmatrhd @rohilsurana can you folks please check this?

@rahmatrhd
Copy link
Member

@bsushmith can you add default values in https://github.com/odpf/charts/blob/main/stable/guardian/values.yaml for running guardian jobs as well?

@bsushmith
Copy link
Member Author

@bsushmith can you add default values in https://github.com/odpf/charts/blob/main/stable/guardian/values.yaml for running guardian jobs as well?

@rahmatrhd will add that as a separate pr once this is done since that would involve updating app dependency in the guardian chart.

@ravisuhag ravisuhag merged commit 8c1aacf into main Jul 26, 2022
@ravisuhag ravisuhag deleted the guardian-jobs branch July 26, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants