-
Notifications
You must be signed in to change notification settings - Fork 11
feat(app): Add cron jobs to app chart #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is it possible to have this as part of stable/guardian only? |
@bsushmith Yes, let's make this part of the Guardian chart only. cc @rahmatrhd |
@ravisuhag @rahmatrhd made the changes as part of the app chart itself. Felt it could be useful for other applications, so instead of just for guardian, added to app chart itself directly. |
@rahmatrhd @rohilsurana can you folks please check this? |
@bsushmith can you add default values in https://github.com/odpf/charts/blob/main/stable/guardian/values.yaml for running guardian jobs as well? |
@rahmatrhd will add that as a separate pr once this is done since that would involve updating app dependency in the guardian chart. |
Ties up with this guardian issue - raystack/guardian#191 to be able to run guardian jobs separately as cron jobs.