[rtextures] fix integer overflow in cast for ImageBlurGaussian
#5037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrisonhh
changed the title
ImageBlurGaussianImageBlurGaussian
|
@garrisonhh Oh! Good catch! Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a weird bug where
ImageBlurGaussianwithblurSize=1added weird discolored lines:The bug happens in the final 'reverse premultiply' step where a rounding error can produce RGB color values that are >=256.0. When cast back to unsigned char for storage, this overflows to zero -- producing colors that are way off. This fix rounds these values down to 255 instead.