using vim.keymap.set, breaking changes

[ray-x]

Moving to new neovim API for key binding

The new way to bind a key is
{ key = 'gr', func = require('navigator.reference').async_ref, doc = 'async_ref' },
doc field is optional
Also as vim.keymap.set() only supported 0.7.x and greater so 0.6.x might no longer works.

Benefits:

1. will not deprecate for a while
2. native lua callback

But you may need to update the config if you override default keymappings. The string search will not work
e.g. in old config
{ key = 'gD', func = 'definition()'},
definition() is used to replace the internal old mapping
{ key = 'gd', func = 'definition()'},
and key gd will be removed from default config.

The new config
{ key = 'gD', func = vim.lsp.buf.definition},
new default:
{ key = 'gd', func = vim.lsp.buf.definition, doc='definition'},
It will search if function reference vim.lsp.buf.definition matches.

[avently]

doc field is optional

https://github.com/ray-x/navigator.lua/blob/master/lua/navigator/lspclient/mapping.lua#L213

Error executing vim.schedule lua callback: .../start/navigator.lua/lua/navigator/lspclient/mapping.lua:213: bad argument #1 to 'find' (string expected, got nil)

And the most strange part.
Icons overriding is broken in some unique way.
When I specify this:

require'navigator'.setup({
debug = false,
        lsp = {
          code_action = {
            virtual_text = false
          },
          diagnostic = {
            update_in_insert = false
          },
          format_on_save = false,
          disable_lsp = { "rust_analyzer" }
        },
        lsp_installer = true,
        lsp_signature_help = false,
        signature_help_cfg = nil,
 keymaps = {
-- THIS LINE AND ONLY THIS COMMAND MAKES ICONS NON WORKING. Other commands I add works fine. Removing this line makes everything working fine too
          { key = '<leader>ld', func = require('navigator.diagnostics').show_buf_diagnostics, doc = 'show_buf_diagnostics' },
 },
icons = {
diagnostic_virtual_text = ''
}
})

So diagnostic_virtual_text icon I specify is not used. Only your icon from source code is used and I know that because I see broken icon in it's place (I don't have nerd fonts). I just found this out by removing line-by-line from my config and this is what causes the icon to not be used. Who knows why...

Do know what can be a cause?

[ray-x]

@avently
Seems there are some dependency issues in the diagnostics module.
Pushed an update: 56b00b8

[avently]

Yep, now diagnostics icon is working, thanks!