iommu: bcm2712-iommu: Add locking; fix address offset; tidy #6939
+34
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
njhollinghurst
commented
Jul 4, 2025
njhollinghurst
commented
- Now using spin_lock_irqsave in map, unmap, sync and iova_to_phys.
- Simplify bounds checks as all allocations should be in aperture.
- Use iommu_iotlb_gather_add_range(); NB gather range is inclusive.
- Fix missing address offset in bcm2712_iommu_sync_all.
- Now using spin_lock_irqsave in map, unmap, sync and iova_to_phys. - Simplify bounds checks as all allocations should be in aperture. - Use iommu_iotlb_gather_add_range(); NB gather range is inclusive. - Fix missing address offset in bcm2712_iommu_sync_all. Signed-off-by: Nick Hollinghurst <[email protected]>
njhollinghurst
force-pushed
the
iommu_20250704
branch
from
5b3c716 to
bec3ae2
Compare
|
Briefly tested with This does not fix any observed bug, but it feels like an improvement. The spin_lock was previously initialized but never used. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jul 7, 2025
kernel: vcsm-cma fixes for lockdep warnings See: raspberrypi/linux#6929 kernel: dtoverlay: Add autorepeat option to gpio-key overlay See: raspberrypi/linux#6933 kernel: drivers: media: cfe: Workaround for 16-bit mismatch in the hardware See: raspberrypi/linux#6935 kernel: configs: Enable more packet classification options See: raspberrypi/linux#6938 kernel: overlays: ili9881-7inch: Fix overlay name in preamble See: raspberrypi/linux#6940 kernel: iommu: bcm2712-iommu: Add locking; fix address offset; tidy See: raspberrypi/linux#6939
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jul 7, 2025
kernel: vcsm-cma fixes for lockdep warnings See: raspberrypi/linux#6929 kernel: dtoverlay: Add autorepeat option to gpio-key overlay See: raspberrypi/linux#6933 kernel: drivers: media: cfe: Workaround for 16-bit mismatch in the hardware See: raspberrypi/linux#6935 kernel: configs: Enable more packet classification options See: raspberrypi/linux#6938 kernel: overlays: ili9881-7inch: Fix overlay name in preamble See: raspberrypi/linux#6940 kernel: iommu: bcm2712-iommu: Add locking; fix address offset; tidy See: raspberrypi/linux#6939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.