Skip to content

update project name to 'legate-boost' #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

jameslamb
Copy link
Member

Contributes to #115.

Clarifies that the project name is legate-boost (with a -).

As of this PR, this project would have the following spellings.

Installation:

conda install legate-boost

pip install legate-boost

Python:

import legateboost

C++

namespace legateboost { ...

legateboost::PredictTask::register_variants();

Shared library:

liblegateboost.so

CMake:

project(legateboost ...

add_library(legateboost ...

Notes for Reviewers

I searched for these like this:

git grep -i legateboost

I choose to leave unchanged anything that seemed to be a reference to the project in general, not the Python package specifically.

For example:

# Memory usage in Legateboost

"LegateBoost does not currently support complex data."

Let me know if you think any of those should be changed too.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 1, 2024
@jameslamb jameslamb requested a review from RAMitchell August 1, 2024 21:28
@jameslamb jameslamb marked this pull request as ready for review August 1, 2024 21:30
@jameslamb jameslamb merged commit f58dbe8 into rapidsai:main Aug 2, 2024
3 checks passed
@jameslamb jameslamb deleted the project-name branch August 2, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants