Compilation optimizations - batch 1 #5112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
seunghwak
approved these changes
Jun 10, 2025
| { | ||
| return variant_type_dispatch(v, [](auto& v) { | ||
| using T = typename std::remove_reference<decltype(v)>::type::value_type; | ||
| return static_cast<arithmetic_device_span_t>(raft::device_span<T>(v.data(), v.size())); |
There was a problem hiding this comment.
Minor thing but isn't arithmetic_device_span_t(raft::device_span<T>(v.data(), v.size())) sufficient? And assigning a span to a variant of span might be more intuitive than statically casting a span to a variant of a span.
There was a problem hiding this comment.
Yes, that would be better. I'll fix that in batch 2 of the changes.
jnke2016
approved these changes
Jun 10, 2025
|
/merge |
rapids-bot
bot
merged commit d3fa655
into
rapidsai:branch-25.08
288 of 305 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking previous PR into smaller chunks. Should be easier to diagnose issues causing failures of tests in CI.
Batch 1: add arithmetic variant types, first use in groupby and count functions.
2% reduction in size of libcugraph.so