Skip to content

Refactor Python Neighborhood Sample #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Mar 19, 2025

A new sampling API supporting both homogeneous and heterogeneous fanout type was exposed to the PLC API along with a biased version of neighborhood sampling.

This PR exposes the new sampling API to the python layer and removes deprecated API/calls/arguments.

closes #3855
closes #4358
closes #3856

@jnke2016 jnke2016 requested a review from a team as a code owner March 19, 2025 19:14
@jnke2016 jnke2016 self-assigned this Mar 19, 2025
@jnke2016 jnke2016 added this to the 25.04 milestone Mar 19, 2025
@jnke2016 jnke2016 marked this pull request as draft March 19, 2025 19:16
Copy link

copy-pr-bot bot commented Mar 19, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 20, 2025
@jnke2016 jnke2016 marked this pull request as ready for review March 20, 2025 12:03
@jnke2016 jnke2016 requested a review from a team as a code owner March 25, 2025 23:11
@rlratzel rlratzel changed the base branch from branch-25.04 to branch-25.06 April 2, 2025 23:09
@rlratzel rlratzel modified the milestones: 25.04, 25.06 Apr 2, 2025
@alexbarghi-nv
Copy link
Member

@jnke2016 I think we can resume this PR now that the code causing issues has been removed.

@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit ae7a399 into rapidsai:branch-25.06 May 28, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the Python Sampling Algorithms Remove "With Edge Properties" Sampling Option from Python API Remove Old Sampling C API and PLC Functions
3 participants