-
Notifications
You must be signed in to change notification settings - Fork 329
Refactor Python Neighborhood Sample #4988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 29 commits into
rapidsai:branch-25.06
from
jnke2016:branch-25.04_refactor-neighbor-sample
May 28, 2025
Merged
Refactor Python Neighborhood Sample #4988
rapids-bot
merged 29 commits into
rapidsai:branch-25.06
from
jnke2016:branch-25.04_refactor-neighbor-sample
May 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rlratzel
requested changes
Mar 26, 2025
python/cugraph/cugraph/sampling/heterogeneous_neighbor_sample.py
Outdated
Show resolved
Hide resolved
python/cugraph/cugraph/sampling/heterogeneous_neighbor_sample.py
Outdated
Show resolved
Hide resolved
python/cugraph/cugraph/sampling/heterogeneous_neighbor_sample.py
Outdated
Show resolved
Hide resolved
…4_refactor-neighbor-sample
rlratzel
approved these changes
Apr 2, 2025
@jnke2016 I think we can resume this PR now that the code causing issues has been removed. |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmarks
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new sampling API supporting both homogeneous and heterogeneous fanout type was exposed to the PLC API along with a biased version of neighborhood sampling.
This PR exposes the new sampling API to the python layer and removes deprecated API/calls/arguments.
closes #3855
closes #4358
closes #3856