[CTK 12.5]: Avoid another compiler issue with host device detection #4971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NVCC seems to also incorrectly deduce this in 12.5
|
This is the last issue in getting rapids to build with CCCL main see https://github.com/NVIDIA/cccl/actions/runs/13822026368/job/38669398923?pr=4123#step:6:12069 |
bdice
approved these changes
Mar 13, 2025
bdice
added
improvement
miscco
changed the title
miscco
commented
Mar 13, 2025
seunghwak
approved these changes
Mar 13, 2025
seunghwak
reviewed
Mar 13, 2025
ChuckHastings
approved these changes
Mar 14, 2025
|
/merge |
miscco
added a commit
to miscco/cugraph
that referenced
this pull request
Mar 19, 2025
…ection (rapidsai#4971)" This reverts commit 6759645.
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
We found the issue to be in some unclear compile issues within libcu++ `not_fn`, so we can revert all those hacks Revert "Silence compiler warnings about host device destructor (#4960)" Revert "[CTK 12.5]: Avoid another compiler issue with host device detection (#4971)" Authors: - Michael Schellenberger Costa (https://github.com/miscco) Approvers: - Seunghwa Kang (https://github.com/seunghwak) URL: #4985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVCC seems to also incorrectly deduce this in 12.5