add setuptools to host requirements for conda packages that need it #4582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@caryr35 pointed out to me this morning that
cugraph
's nightly CI is failing. Allconda-python-build
jobs are failing like this, when buildingnx-cugraph
(build link)
suspected root cause:
nx-cugraph
usessetuptools.build_meta
, butsetuptools
isn't present in the conda build environmentNotes for Reviewers
Why is this targeting
branch-24.08
?Looks like CI is failing there too: https://github.com/rapidsai/cugraph/actions/runs/10183681336/job/28171285190
Why is this just breaking now?
I suspect that prior to this we were getting
setuptools
because it was a transitive dependency of one ofnx-cugraph
's other build/host dependencies.How could we prevent stuff like this in the future?
We could add support for updating conda recipe files in
rapids-dependency-file-generator
(rapidsai/dependency-file-generator#7).setuptools
was correctly added as a build dependency inpyproject.toml
files here (automatically, viadependencies.yaml
+rapids-dependency-file-generator
), but the conda recipemeta.yaml
files were missed.