Skip to content

Adds the latest docs code from cugraph repo #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

acostadon
Copy link
Contributor

Adds the latest docs code from cugraph repo also adds pyg to conda environment which is necessary to build docs.
Resolves #58

@acostadon acostadon added conda Relates to conda packaging doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Dec 17, 2024
@acostadon acostadon self-assigned this Dec 17, 2024
@acostadon acostadon closed this Dec 17, 2024
@acostadon acostadon reopened this Dec 17, 2024
@acostadon acostadon marked this pull request as ready for review December 18, 2024 14:21
@acostadon acostadon requested review from a team as code owners December 18, 2024 14:21
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few items:

  1. Now that all the docs are in one place, you might want to create subfolders under "_static" to organize files
  2. The blogs and papers section is out of date

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's fix the CI failures in #46 first, and then once that's merged this should build successfully.

@jameslamb jameslamb removed the request for review from AyodeAwe December 18, 2024 16:27
@jameslamb
Copy link
Member

I just pushed some updates here in cda23fd

  • added cugraph-pyg to dependencies.yaml
  • added a CI job to check that files like conda environment files in the repo match dependencies.yaml
  • updated pre-commit hooks to their latest versions by running pre-commit autoupdate
  • remove the CUDA 11.8 and CUDA 12.2 conda env files checked into the repo, added a CUDA 12.5 one
    • the files in conda/environments/ are only meant for interactive development, they don't affect CI
    • CI is using the latest CUDA version RAPIDS supports, currently 12.5, so I think it's useful to have the local environment match
    • ref:
      container_image: "rapidsai/ci-conda:latest"

Will add some inline comments explaining these changes too.

@@ -12,9 +13,9 @@ files:
- depends_on_cugraph
- depends_on_dgl
- depends_on_cugraph_dgl
- depends_on_cugraph_pyg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change, adding depends_on_cugraph_pyg to the all: dependency list, causes rapids-dependency-file-generator to automatically put the appropriate version of it into the file(s) in conda/environments/

@acostadon
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1194e74 into rapidsai:branch-25.02 Dec 18, 2024
8 of 9 checks passed
@jameslamb
Copy link
Member

🎉 the build on branch-25.02 for this succeeded!

upload: ../../../tmp/tmp.sHVdT5Gr72/cugraph-docs/html/wholegraph/installation/index.html to s3://rapidsai-docs/cugraph-docs/html/25.02/wholegraph/installation/index.html

https://github.com/rapidsai/cugraph-docs/actions/runs/12398664118/job/34611886692

@acostadon acostadon mentioned this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda Relates to conda packaging doc Improvements or additions to documentation non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get cugraph-docs library fully up-to-date will all 25.02 changes from cugraph
3 participants