Skip to content

🚧 Deduplicate parquet physical type enums #18526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 25 commits into
base: branch-25.06
Choose a base branch
from
Draft

🚧 Deduplicate parquet physical type enums #18526

wants to merge 25 commits into from

Conversation

mhaseeb123
Copy link
Member

@mhaseeb123 mhaseeb123 commented Apr 18, 2025 •
edited
Loading

Description

Closes #18525. Merge after #18480

🚧 This PR removes the duplicated TypeKind enum representing Parquet physical types and updates its use with the Type enum defined in parquet_schema.hpp

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

mhaseeb123 and others added 23 commits April 10, 2025 00:53
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 18, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Apr 18, 2025
@mhaseeb123 mhaseeb123 added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 18, 2025
@mhaseeb123 mhaseeb123 added cuIO cuIO issue breaking Breaking change and removed non-breaking Non-breaking change labels Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhaseeb123 mhaseeb123

Labels
2 - In Progress Currently a work in progress breaking Breaking change CMake CMake build issue cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Deduplicate TypeKind and Type enums in parquet_metadata.hpp and parquet_schema.hpp
1 participant
@mhaseeb123