Skip to content

Don't fetch dlpack headers when building cuDF Python #18518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

Don't fetch dlpack headers when building cuDF Python #18518

merged 2 commits into from
Apr 21, 2025

Conversation

mroeschke
Copy link
Contributor

Description

This is now done in pylibcudf where dlpack conversions are defined: https://github.com/rapidsai/cudf/blob/branch-25.06/python/pylibcudf/CMakeLists.txt#L33

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 17, 2025
@mroeschke mroeschke self-assigned this Apr 17, 2025
@mroeschke mroeschke requested a review from a team as a code owner April 17, 2025 18:09
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Apr 17, 2025
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ead6fdb into rapidsai:branch-25.06 Apr 21, 2025
111 checks passed
@mroeschke mroeschke deleted the rm/dlpack/cmakelists branch April 21, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees

@mroeschke mroeschke

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @bdice