Skip to content

Automate bundle tests #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Automate bundle tests #337

wants to merge 3 commits into from

Conversation

sbulage
Copy link
Collaborator

@sbulage sbulage commented Jun 5, 2025

No description provided.

@sbulage sbulage self-assigned this Jun 5, 2025
@sbulage sbulage added the automation Add or update automation label Jun 5, 2025
@sbulage sbulage linked an issue Jun 5, 2025 that may be closed by this pull request
@sbulage sbulage force-pushed the automate-bundle-tests branch from cd809a7 to 2e27bfc Compare June 9, 2025 11:02
@sbulage sbulage marked this pull request as ready for review June 9, 2025 11:02
@sbulage
Copy link
Collaborator Author

sbulage commented Jun 9, 2025

Newly written tests are skipped because tests should not run on 2.11 and older versions...
See here: https://github.com/rancher/fleet-e2e/actions/runs/15532999979/job/43725883371?pr=337#step:9:528

@sbulage
Copy link
Collaborator Author

sbulage commented Jun 9, 2025

@sbulage
Copy link
Collaborator Author

sbulage commented Jun 9, 2025

CI for 2.12.0-alpha6

@sbulage
Copy link
Collaborator Author

sbulage commented Jun 9, 2025

On PR CI, Fleet-127 test failed...apart from that the tests in this PR should skip on 2.11 and are skipping: https://github.com/rancher/fleet-e2e/actions/runs/15532999979/job/43733799480?pr=337#step:9:505

@sbulage sbulage requested a review from mmartin24 June 10, 2025 06:07
@@ -14,3 +16,35 @@ export const isK8sVersion = (version: string) => {
export const isRancherManagerVersion = (version: string) => {
return (new RegExp(version)).test(Cypress.env("rancher_version"));
}

// Run `It()` block based on allowedVersions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my understanding not exclusively to It() blocks. Suggest change: It() / Describe() blocks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try and make it describe level version mapping.

Copy link
Collaborator

@mmartin24 mmartin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Small consideration change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Add or update automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automation for Bundle creation from GitRepo
2 participants