Skip to content

Switching from using the stale-issue-label to the only-issue-labels option #14136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

codyrancher
Copy link
Member

@codyrancher codyrancher commented Apr 15, 2025

Summary

The stale-issue-label removed the label from the issue after it's closed. We don't want to remove the kind/enhancement labels.

The new change may add a stale label before we close the issue but we're testing that.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

…s` option

The `stale-issue-label` removed the label from the issue after it's closed. We don't want to remove the kind/enhancement labels.
@@ -14,9 +14,9 @@ jobs:
steps:
- uses: actions/stale@v9
with:
debug-only: true # Dry-run
debug-only: true # Uncomment to switch back to dry-run
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to leave this line in just commented out once we enable this. I'm leaving this so we don't have to go look at docs in case we want to switch to dry-run quickly.

I recognize that we can just disable the workflow if needed.

@codyrancher codyrancher requested a review from nwmac April 15, 2025 20:53
@codyrancher codyrancher added this to the v2.12.0 milestone Apr 15, 2025
@codyrancher codyrancher marked this pull request as ready for review April 15, 2025 20:54
@codyrancher codyrancher merged commit 019581f into rancher:master Apr 17, 2025
52 of 61 checks passed
@codyrancher codyrancher deleted the stale-take-2 branch April 17, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants