Skip to content

Github action for releasing new versions #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

belgaied2
Copy link
Contributor

What this PR does / why we need it:
This PR implements a GitHub Action for releasing new versions of the provider. It also fixes a small issue which potentially causes a nil pointer dereference in the Bootstrap controller.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Mohamed Belgaied Hassine <[email protected]>

added Go setup to release action

Signed-off-by: Mohamed Belgaied Hassine <[email protected]>

Fixed nil pointer dereference caused by NTP servers feature

Signed-off-by: Mohamed Belgaied Hassine <[email protected]>

modifying Makefile behavior to keep kustomize config files intact

Signed-off-by: Mohamed Belgaied Hassine <[email protected]>
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@belgaied2 belgaied2 merged commit 49de66c into rancher:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants