Example manifests for VMWare #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
previously approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Looks good to me, we will have to add instructions on uploading machine image later when we have some, similar to this doc https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/docs/getting_started.md#uploading-the-machine-images
Signed-off-by: Bas van Kampen <[email protected]>
bvankampen
force-pushed
the
vmware-examples
branch
from
db24c9a to
042d2eb
Compare
|
@alexander-demicev Yes no problem, they will be mostly the same as the VMware instructions. I will add them later. Also I think I removed your approval when I added my signoff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/examples
What this PR does / why we need it:
Add example manifiest for provisioning RKE2 clusters on VMware.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Missing examples for VMware
Special notes for your reviewer:
Checklist: