Skip to content

Allow using Gzip and GzipBase64 encoding in case of cloud-init format #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

a-bouts
Copy link
Contributor

@a-bouts a-bouts commented Apr 28, 2025

What this PR does / why we need it:

When configuring RKE2ControlPlane with a file using gzip+base64 encoding, the bootstrap controller fails with the error :

spec.files[2].encoding: Forbidden: not supported when spec.format is set to "ignition"

Even if the format used is cloud-init.

This PR validates the file encoding is not gzip or gzip+base64 only in case of ignition format.

@a-bouts a-bouts requested a review from a team as a code owner April 28, 2025 22:06
@alexander-demicev alexander-demicev moved this to PR to be reviewed in CAPI / Turtles Apr 29, 2025
@Danil-Grigorev Danil-Grigorev added this pull request to the merge queue Apr 29, 2025
@furkatgofurov7 furkatgofurov7 added the area/bootstrap Indicates an issue or PR related to the bootstrap provider label Apr 29, 2025
@furkatgofurov7 furkatgofurov7 added the kind/refactor Denotes a change that is a refactor label Apr 29, 2025
Merged via the queue into rancher:main with commit 0594e60 Apr 29, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from PR to be reviewed to Done in CAPI / Turtles Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Indicates an issue or PR related to the bootstrap provider kind/refactor Denotes a change that is a refactor
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants