-
Notifications
You must be signed in to change notification settings - Fork 43
✨ Support RKE2ControlPlane mhc remediation #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR 👍🏼
I have not looked into the logic yet, but can you please first rename the KCP mentions with RKE2ControlPlane everywhere (comments, file names, vars etc)?
Hey @furkatgofurov7, done. The only place where i left kcp is in tests, because i've used the standard capi |
f3fff44
to
50446ee
Compare
@MaxFedotov you can run |
@furkatgofurov7, done |
hey @furkatgofurov7! Is there anything else i can do to proceed with this PR? Thanks! |
6c7b9d7
aa8fd1f
to
ba4e051
Compare
Sorry for the force push, had to rebase the branch to the latest main to fix the conflicts |
aaa45ce
to
600be9a
Compare
@furkatgofurov7 done, changes in makefile and dockerfile rollbacked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaxFedotov thanks for patience and taking a time to address the review comments. This change LGTM, can you please squash the commits as much as needed to avoid duplicate commit messages to have a logically coherent commit flow? Thanks!
39573d6
to
cb4019b
Compare
…ve cluster-template-rcp-remediation to a separate InfrastructureProvider config
cb4019b
to
a509f5b
Compare
@furkatgofurov7 done! |
@furkatgofurov7 looking on the test error and the cluster-api code, template name should be I will make a commit with rename, can we try to run the tests using the |
All tests green, great :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for the PR!
kind/feature
What this PR does / why we need it:
This PR adds support for RKE2ControlPlane remediation. The code is taken from KCP (https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/internal/controllers/remediation.go) and adopted for RKE2. It also adds a new
rcp_remediation_test
e2e test, based on CAPI e2eKCPRemediationSpec
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #626
Special notes for your reviewer:
Checklist: