Skip to content

Propagate cloud provider config #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Feb 5, 2025

kind/bug

What this PR does / why we need it:

This fixes the absence of the cloud-provider-name in the generated /etc/rancher/rke2/config.yaml

Consider this an hotfix. Due to the nature of the code, it seems to generate duplicate files. It's safe to ignore.
A proper fix would probably need refactoring of the entire bootstrap generation logic to make it more maintainable and understandable.

For example:

          {
              Path: "/etc/rancher/rke2/audit-policy.yaml",
              Owner: "root:root",
              Permissions: "0644",
              Encoding: "",
              Content: "test_audit",
              ContentFrom: nil,
          },
          {
              Path: "/etc/rancher/rke2/cloud-provider-config",
              Owner: "root:root",
              Permissions: "0644",
              Encoding: "",
              Content: "test_cloud_config",
              ContentFrom: nil,
          },
          {
              Path: "/etc/rancher/rke2/etcd-s3-ca.crt",
              Owner: "root:root",
              Permissions: "0640",
              Encoding: "",
              Content: "test_ca",
              ContentFrom: nil,
          },
          {
              Path: "/etc/rancher/rke2/cloud-provider-config",
              Owner: "root:root",
              Permissions: "0644",
              Encoding: "",
              Content: "test_cloud_config",
              ContentFrom: nil,
          },

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #567

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti requested a review from a team as a code owner February 5, 2025 13:12
@anmazzotti anmazzotti self-assigned this Feb 5, 2025
@anmazzotti anmazzotti added the kind/bug Something isn't working label Feb 5, 2025
@alexander-demicev alexander-demicev requested a review from a team February 5, 2025 17:28
@anmazzotti anmazzotti merged commit fcee715 into rancher:main Feb 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

serverConfig.cloudProviderName is ignored on initial control plane provisioning
3 participants