Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/bug
What this PR does / why we need it:
This fixes the absence of the
cloud-provider-name
in the generated/etc/rancher/rke2/config.yaml
Consider this an hotfix. Due to the nature of the code, it seems to generate duplicate files. It's safe to ignore.
A proper fix would probably need refactoring of the entire bootstrap generation logic to make it more maintainable and understandable.
For example:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #567
Special notes for your reviewer:
Checklist: