Skip to content

Add nested virtualization checks for linux #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2023
Merged

Add nested virtualization checks for linux #3707

merged 1 commit into from
Jan 7, 2023

Conversation

alextychan
Copy link
Contributor

Fix for #3706

Either 'Y' or '1` is a valid value when enabling nested virtualization. As stated here

Added checks for '1' flag in 'background.ts'

jandubois
jandubois requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me, but I don't understand why you have a version of Eric's factory-reset.md commit in your branch.

Can you do a rebase on latest main to clean that up before we merge? Thanks!

@alextychan alextychan requested a review from jandubois January 7, 2023 03:52
@jandubois jandubois merged commit 2b0899f into rancher-sandbox:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alextychan @jandubois