This repository was archived by the owner on Jan 21, 2024. It is now read-only.
Fixes #29: Make getDeclarationByName work with type expressions #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs to be updated a little. |
postatum
changed the title
jstoiko
suggested changes
Jul 18, 2019
| @@ -27,8 +27,8 @@ val settings = Common.settings ++ Common.publish ++ Seq( | |||
| credentials ++= Common.credentials(), | |||
| libraryDependencies ++= Seq( | |||
| "org.scalatest" %%% "scalatest" % "3.0.5" % "test", | |||
| "com.github.amlorg" %%% "amf-webapi" % "3.2.1", | |||
| "com.github.amlorg" %%% "amf-validation" % "3.2.1" | |||
| "com.github.amlorg" %%% "amf-webapi" % "3.2.2", | |||
There was a problem hiding this comment.
@jstoiko can we make this upgrade in a separate PR?
Release 3.3.0 adds breaking changes (section "Interface Changes") which may break things in webapi-parser code and/or examples. There will be too much in this PR if we fix migration issues here.
There was a problem hiding this comment.
Also see aml-org/amf#542
|
Done reworking the PR. |
postatum
changed the title
jstoiko
approved these changes
Jul 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Things that need to be done after changes of this PR are released:
Breaking changes
This PR presents potentially breaking changes for Java users. In particular
WebApiBaseUnit.getDeclarationByNamenow returns an instance ofamf.client.model.domain.AnyShapeinstead ofamf.client.model.domain.NodeShape. Note thatNodeShapeis a subclass ofAnyShapeas API docs state.Considering this, you might need to explicitly convert an instance of
AnyShapereturned byWebApiBaseUnit.getDeclarationByNameto its subclasses to access subclass-specific properties.E.g. to access UnionShape.anyOf property you would have to do:
JS users should face no breaking changes.