Make IO::Socket::SSL do the IO::Socket role #21
Conversation
| @@ -11,7 +11,6 @@ sub v6-split($uri) { | |||
| $host ?? ($host, $port) !! $uri; | |||
| } | |||
|
|
|||
| has Str $.encoding = 'utf8'; | |||
There was a problem hiding this comment.
This was removed because otherwise applying the role would die with Attribute '$!encoding' already exists in the class 'IO::Socket::SSL', but a role also wishes to compose it. However, it should be safe to remove, since IO::Socket provides the same default: https://github.com/rakudo/rakudo/blob/master/src/core.c/IO/Socket.pm6#L3
lib/IO/Socket/SSL.pm6
Outdated
| @@ -126,6 +125,10 @@ method print(Str $s) { | |||
| $!ssl.write($s); | |||
| } | |||
|
|
|||
| method put(Str $s) { | |||
| $!ssl.write($s ~ "\n"); | |||
There was a problem hiding this comment.
Well spotted. I changed it to $!nl-out, or do you think it's preferable to use the accessor?
There was a problem hiding this comment.
I generally try to avoid calling private accessors that come from outside the class (composed in from roles). It is fine (to me) for IO::Socket to call $!nl-out because it is declared in that class and thus the implementation details can be hidden. Using $.nl-out outside of IO::Socket is ok because it ensures it will use the public interface (maybe in the future there is no $!nl-out, only method nl-out { ... })
There was a problem hiding this comment.
Good point. Amended
This makes it possible to assign an IO::Socket::SSL to a variable with an IO::Socket constraint. Without this, doing so would result in a hard to understand segmentation fault. In order for this work, the `put` method is also naively implemented.
This makes it possible to assign an IO::Socket::SSL to a variable
with an IO::Socket constraint. Without this, doing so would result
in a hard to understand segmentation fault.
In order for this work, the
putmethod is also naively implemented.This fixes #20 and likely #3.