Skip to content

Fix possible crash with save_input_history (See #26) #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

rakshasa
Copy link
Owner

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)


DownloadList* download_list() { return m_downloadList; }
DownloadList* download_list() { return m_downloadList.get(); }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for private member m_downloadList

Suggested change
DownloadList* download_list() { return m_downloadList.get(); }
DownloadList* download_list() { return m_download_list.get(); }

Control* m_control;
DownloadList* m_downloadList;
Control* m_control{nullptr};
std::unique_ptr<DownloadList> m_downloadList;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for private member m_downloadList

Suggested change
std::unique_ptr<DownloadList> m_downloadList;
std::unique_ptr<DownloadList> m_download_list;

WTitle* window_title() { return m_windowTitle; }
WStatusbar* window_statusbar() { return m_windowStatusbar; }
WInput* window_input() { return m_windowInput; }
WTitle* window_title() { return m_windowTitle.get(); }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for private member m_windowTitle

Suggested change
WTitle* window_title() { return m_windowTitle.get(); }
WTitle* window_title() { return m_window_title.get(); }

WHttpQueue* m_windowHttpQueue;
WInput* m_windowInput;
WStatusbar* m_windowStatusbar;
std::unique_ptr<WTitle> m_windowTitle;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for private member m_windowTitle

Suggested change
std::unique_ptr<WTitle> m_windowTitle;
std::unique_ptr<WTitle> m_window_title;

WInput* m_windowInput;
WStatusbar* m_windowStatusbar;
std::unique_ptr<WTitle> m_windowTitle;
std::unique_ptr<WHttpQueue> m_windowHttpQueue;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for private member m_windowHttpQueue

Suggested change
std::unique_ptr<WHttpQueue> m_windowHttpQueue;
std::unique_ptr<WHttpQueue> m_window_http_queue;

WInput* window_input() { return m_windowInput; }
WTitle* window_title() { return m_windowTitle.get(); }
WStatusbar* window_statusbar() { return m_windowStatusbar.get(); }
WInput* window_input() { return m_windowInput.get(); }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for private member m_windowInput

Suggested change
WInput* window_input() { return m_windowInput.get(); }
WInput* window_input() { return m_window_input.get(); }

WStatusbar* m_windowStatusbar;
std::unique_ptr<WTitle> m_windowTitle;
std::unique_ptr<WHttpQueue> m_windowHttpQueue;
std::unique_ptr<WInput> m_windowInput;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for private member m_windowInput

Suggested change
std::unique_ptr<WInput> m_windowInput;
std::unique_ptr<WInput> m_window_input;

WStatusbar* window_statusbar() { return m_windowStatusbar; }
WInput* window_input() { return m_windowInput; }
WTitle* window_title() { return m_windowTitle.get(); }
WStatusbar* window_statusbar() { return m_windowStatusbar.get(); }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for private member m_windowStatusbar

Suggested change
WStatusbar* window_statusbar() { return m_windowStatusbar.get(); }
WStatusbar* window_statusbar() { return m_window_statusbar.get(); }

std::unique_ptr<WTitle> m_windowTitle;
std::unique_ptr<WHttpQueue> m_windowHttpQueue;
std::unique_ptr<WInput> m_windowInput;
std::unique_ptr<WStatusbar> m_windowStatusbar;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ readability-identifier-naming ⚠️
invalid case style for private member m_windowStatusbar

Suggested change
std::unique_ptr<WStatusbar> m_windowStatusbar;
std::unique_ptr<WStatusbar> m_window_statusbar;

@rakshasa rakshasa merged commit 47af28a into master Mar 11, 2025
2 checks passed
@rakshasa rakshasa deleted the chros73-fix_save_input_history-2 branch March 11, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants