-
Notifications
You must be signed in to change notification settings - Fork 30
Issue compiling a project with required_ruby_version >= 3.2.0
#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Congratulations on being the first project to try to drop Ruby 3.1 from their precompiled gem! For sure this is a problem that I did not see coming. In flavorjones/ruby-c-extensions-explained#40 I tested this:
The issue here is that, in the container, the default Ruby version is 3.1! Ugh. You can work around this in the short-term by removing the min ruby version requirement from the gemspec (unless that determines the value of RUBY_CC_VERSION for rake-compiler? I'm not familiar with how your gem or rb-sys works.). The ruby version requirement will be set properly in the packaged gem's gemspec regardless. In the meantime, I'll find some time to try to fix this. |
Because Ruby 3.1 as the default doesn't work if gems want to drop 3.1 Closes #145
Work ongoing at #146, I'd like to play with it a bit so it may be a few days before that branch lands on master and I cut a release. |
I was directed here after discussion on https://github.com/oxidize-rb/rb-sys Slack. I am using their tool
rb-sys-dock
to cross-compile a Rust-based C-extension, and it just delegates most of the compilation to this one. I have upgraded my project's gemspec to haverequired_ruby_version = '>= 3.2.0'
because I no longer want to build for 3.1.0 and I have 3.2.0-specific things. But it is breaking (I did this at temporalio/sdk-ruby#194 before I reverted it to keep at >= 3.1.0 due to this break). The CI action outputted:@jbourassa helpfully pointed out that rb-sys-dock just invokes this at https://github.com/oxidize-rb/rb-sys/blob/0efd9519fb0bd3808794895ede73a1cd008fdeb7/gem/exe/rb-sys-dock#L373-L404 and the docker container is fixed to 3.1 at https://github.com/rake-compiler/rake-compiler-dock/blob/c4e7dc390e0757891ad8c7898953f87a35c957dc/Dockerfile.mri.erb#L77C5-L77C17.
Any suggestions on how to build a
>= 3.2.0
withrake-compiler-dock
/rb-sys-dock
?The text was updated successfully, but these errors were encountered: