Skip to content

get_matrix_servers has a hand rolled parser for YAML #6424

Closed
@hackaugusto

Description

@hackaugusto

raiden/raiden/utils/cli.py

Lines 441 to 449 in 9bd24b1

available_servers = []
for line in response.text.splitlines():
line = line.strip(string.whitespace + "-")
if line.startswith("#") or not line:
continue
if not line.startswith("http"):
line = "https://" + line # default schema
available_servers.append(line)
return available_servers

Using a hand rolled parser can be very buggy and most likely will lead to differences across clients. It seems pyyaml is not a dependency anymore, so json would be a better file format since it is used extensively on both clients.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions