Skip to content

Fix for junit failure while using with --early-exit FIX #485 #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

priyacshah
Copy link

Fix #485
In the case of early exit, the subsequent scenarios do not have starttime or endtime. Fixed it to skip those after early exit.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.13%. Comparing base (acae639) to head (db6ee1a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          38       38           
  Lines        2324     2325    +1     
=======================================
+ Hits         2025     2026    +1     
  Misses        299      299           
Flag Coverage Δ
unittests 87.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fliiiix fliiiix self-requested a review March 20, 2025 09:40
@fliiiix fliiiix force-pushed the junit_early_exit_fix branch from 6e47773 to db6ee1a Compare March 21, 2025 07:21
@fliiiix
Copy link
Member

fliiiix commented Mar 21, 2025

Combined the 2 commits into 1, added release notes, run ruff formater to pass pipeline

@fliiiix fliiiix merged commit 49595ea into radish-bdd:main Mar 21, 2025
8 checks passed
@fliiiix
Copy link
Member

fliiiix commented Mar 21, 2025

thanks for the contribution ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radish --early-exit Flag Causes Error: Cannot Get Duration of Scenario in JUnit XML Report
2 participants