Skip to content

fix(callstack): Rework final user frame heuristics #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2025

Conversation

rabbitstack
Copy link
Owner

What is the purpose of this PR / why it is needed?

Change the heuristics for obtaining the final user code stack frame by looking for the presence of modules that do not reference Win32 or Native (ntdll) layers that are intermediary modules for transitioning into kernel land.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


Change the heuristics for obtaining the final
user code stack frame by looking for the presence
of modules not referencing Win32 or Native (ntdll) layers that are intermediary modules for transitioning into kernel land.
@rabbitstack rabbitstack merged commit 6b4602a into master Apr 13, 2025
9 checks passed
@rabbitstack rabbitstack deleted the rework-final-user-callstack-frame branch April 13, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant