Replication bug fixes #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
follower-resend-bug
branch
3 times, most recently
from
52d7fe5 to
f4460a5
Compare
1. Fix bug where occasionally one follower would receive more entries then expected resulting in triggering 2. 2. Fix bug when follower received an append_entries_rpc with no new entries in it would trigger an incorrect resend scenario when throughput is high. 3. Fix bug where a late written event could accidentally confirm unwritten entries in a higher term.
kjnilsson
force-pushed
the
follower-resend-bug
branch
from
f1b3784 to
324d9bc
Compare
|
This should be backported to the 2.15.x branch and a new 2.15.x release should be created. |
kjnilsson
force-pushed
the
follower-resend-bug
branch
4 times, most recently
from
3f392e6 to
73b73af
Compare
Add assertions Add some logging and a test
kjnilsson
force-pushed
the
follower-resend-bug
branch
from
73b73af to
60c2d19
Compare
michaelklishin
approved these changes
Mar 12, 2025
|
@Mergifyio backport v2.15.x |
✅ Backports have been created
|
kjnilsson
added a commit
that referenced
this pull request
Mar 14, 2025
Replication bug fixes (backport #516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where occasionally one follower would receive
more entries then expected resulting in triggering 2.
Fix bug when follower received an append_entries_rpc with
no new entries in it would trigger an incorrect resend
scenario when throughput is high.
Fix bug where a late written event could accidentally confirm
unwritten entries in a higher term.
A replication liveness bug that could cause clusters to get stuck
after a member removal.