Add support for uint16/uint32 #303
Open
+367
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2025 18:15
u and i are field types in the AMQP-0.9.1 spec that correspond to uint16 and uint32 respectively; currently this library throws when encountering these field types. This change adds full support for reading and writing them and resolves rabbitmq#302
|
Thank you for this contribution! I've been busy with other tasks and responsibilities. I'm hoping to get to this PR this week, or worst case, early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u and i are field types in the AMQP-0.9.1 spec that correspond to uint16 and uint32 respectively; currently this library throws when encountering these field types. This change adds full support for reading and writing them and resolves #302. It also includes a test suite exercising all field types in both the read and write pathways.
This change also includes some housekeeping updates to satisfy the linter, which was no longer passing due to issues like not handling returned errors. However, in the interest of full backwards compatibility, this change does not actually return those errors - instead it swallows them with
_to preserve existing behavior.Apart from the new field types, the only potential breaking change is lowercasing a few error messages which started with uppercase letters.