Skip to content

Some improvements to the cURL interface #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

thomasp85
Copy link
Member

This PR encompasses a couple of (in my opinion) improvements to how HTTP requests are handled.

Currently it makes the following changes:

  • data can now be a raw vector instead of a string to avoid translating back and forth if the body is already in raw format
  • The promise interface has been changed to return all relevant information from the response, instead of only the body. The response is now resolved to a list with the elements status, headers, and body. It no longer throws an error on non-2XX responses

I would love to have all headers returned by default (that is response = NULL returns all headers), but AFAIK NNG doesn't allow that for non-obvious reasons

This PR is mainly intended as an inspiration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant