Skip to content

Deprecate QUnit.extend #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
smcclure15 opened this issue Oct 19, 2020 · 1 comment · Fixed by #1495
Closed
2 tasks done

Deprecate QUnit.extend #1491

smcclure15 opened this issue Oct 19, 2020 · 1 comment · Fixed by #1495
Assignees
@smcclure15
Labels
Category: Docs Component: Core For module, test, hooks, and reporters. good first issue Straight-forward to start and receive help with. help welcome Type: Enhancement New idea or feature request.
Milestone
2.x release

Comments

@smcclure15
Copy link
Member

smcclure15 commented Oct 19, 2020 •
edited by Krinkle
Loading

I was suprised to see the QUnit.extend API still fully supported, or at least not marked deprecated.
Would the native Object.assign not suffice, and QUnit can back away from this redundant implementation/support?

  • Mark QUnit.extend as deprecated in code.
  • Update documentation page.
@Krinkle Krinkle added Component: Core For module, test, hooks, and reporters. Type: Enhancement New idea or feature request. labels Oct 21, 2020
@Krinkle Krinkle added this to the 3.0 milestone Oct 21, 2020
@Krinkle
Copy link
Member

Krinkle commented Oct 21, 2020

Object.assign was introduced as part of the ES6 spec and is still relatively new. QUnit offer broader support since its implementation is relatively simple and this allows developers to decide what their supported markets are, without being limited by developer tooling.

At this point, we support IE9+. When we require Edge 12+, we can use Object.assign() internally.

However, I would support soft-deprecating this method in the public API since it is indeed only meant for internal usage. Then in the upcoming QUnit 3 release, it can become a private utility method.

@Krinkle Krinkle added good first issue Straight-forward to start and receive help with. Category: Docs labels Nov 5, 2020
@Krinkle Krinkle removed this from the 3.0 milestone Nov 5, 2020
@Krinkle Krinkle changed the title Clarification on QUnit.extend capabilities/support Deprecate QUnit.extend Nov 5, 2020
@smcclure15 smcclure15 self-assigned this Nov 6, 2020
smcclure15 added a commit to smcclure15/qunit that referenced this issue Nov 6, 2020
@smcclure15
Docs: mark QUnit.extend as deprecated
44bdcde 
Assuming this is deployed in verion 2.12
Addresses qunitjs#1491
@smcclure15 smcclure15 mentioned this issue Nov 6, 2020
Merged
@Krinkle Krinkle added this to the 2.x release milestone Nov 7, 2020
Krinkle pushed a commit that referenced this issue Nov 8, 2020
@smcclure15
Core: Deprecate QUnit.extend
f27c44a 
Internal "extend" utility remains warning-free.
The QUnit.extend entry point issues a warning, and then passes-through.
Updated reporter to no longer use QUnit.extend, but instead the internal implementation.

Closes #1495.
Fixes #1491.
Krinkle pushed a commit that referenced this issue May 29, 2024
@izelnakri @Krinkle
Core: Remove QUnit.extend()
82c4790 
Ref #1491.
Closes #1696.
Krinkle added a commit that referenced this issue May 29, 2024
@Krinkle
Docs: Document removal of QUnit.extend()
335b040 
Ref #1491.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smcclure15 smcclure15

Labels
Category: Docs Component: Core For module, test, hooks, and reporters. good first issue Straight-forward to start and receive help with. help welcome Type: Enhancement New idea or feature request.
Milestone
2.x release
Development

Successfully merging a pull request may close this issue.

Deprecate QUnit.extend smcclure15/qunit
2 participants
@Krinkle @smcclure15