add numbertype=Float64 option #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.32% // Head: 88.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 88.32% 88.36% +0.04%
==========================================
Files 9 9
Lines 1721 1728 +7
==========================================
+ Hits 1520 1527 +7
Misses 201 201
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
quinnj
approved these changes
Nov 3, 2022
|
Would be great if this could be tagged, so I can start using it. |
|
Done: 8569ff9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a part of #198, namely the proposal for
numbertype=Float64support, which I need for reasons explained further down the thread (link).This is not very generic, so it doesn't support
numbertype=BigFloatand the like, since it merely hooks in to the existingcheckintoptional argument which merely signals if it should try to cast a number to integer or not. However it was relatively easy to do and meets my needs, so perhaps it is an ok start?