Skip to content

Exit when chitchat server fails #5819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged

Exit when chitchat server fails #5819

merged 5 commits into from
Jul 15, 2025

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented Jun 25, 2025

Description

Closes #5787

Currently, Quickwit node would keep running if chitchat server stops (panic or error). This PR adds a watcher for this and stops the nodes if something goes wrong in chitchat.

This PR depends on quickwit-oss/chitchat#162

How was this PR tested?

Describe how you tested this PR.

Copy link
Collaborator

@fulmicoton-dd fulmicoton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. let's merge the chitchat PR and update the rev accordingly though

@rdettai rdettai force-pushed the exit-on-chitchat-failure branch 2 times, most recently from df8772f to a129a1a Compare July 10, 2025 10:01
@rdettai rdettai force-pushed the exit-on-chitchat-failure branch from 83c71cc to 2eebb69 Compare July 15, 2025 10:19
@rdettai rdettai enabled auto-merge (squash) July 15, 2025 10:20
@rdettai rdettai merged commit b4bf3c4 into main Jul 15, 2025
8 checks passed
@rdettai rdettai deleted the exit-on-chitchat-failure branch July 15, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control Plane not exiting on panic
2 participants