feat: add scaleConfig finalizer · quickube/QScaler@c2f1055

Triggered via pull request December 7, 2024 14:16

omri2001

opened #16

Status Failure

Total duration 3m 47s

Artifacts –

ci.yml

on: pull_request

5 errors and 1 warning

Run on Ubuntu: internal/controller/scalerconfig_controller.go#L78

(*ScalerConfigReconciler).finalizer - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)

Run on Ubuntu: internal/controller/scalerconfig_controller.go#L105

(*ScalerConfigReconciler).finalizerLogic - result 0 (error) is always nil (unparam)

Run on Ubuntu: internal/controller/scalerconfig_controller.go#L110

(*ScalerConfigReconciler).runLogic - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)

Run on Ubuntu: internal/brokers/main.go#L59

S1033: unnecessary guard around call to delete (gosimple)

issues found

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636