Redis dev services: Add disabled tests for case where multiple profiles share a port #47578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
changed the title
Status for workflow
|
cescoffier
approved these changes
Apr 29, 2025
gsmet
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a fix for the Redis part of #45785, and spotted that the only coverage we have of the scenario where multiple profiles try to use the same port is in the opentelemetry-redis-instrumentation integration test. (This is better than most dev services, which don't cover the case at all).
To bring the problem scenario closer to the relevant dev service, I've added some new tests. They're disabled for the moment, since the multiple-profiles-attempting-to-use-the-same-port scenario stopped working with #34681.
PR for a fix incoming soon.