Try and give more helpful error message for bad surefire version #47492
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion around #34681 (comment)
Detecting surefire is relatively easy, but I couldn't find a great way to detect the version. The best I could do was look at the name of the surefire booter. For Surefire 3.x it ends in
_3
, such asFor Surefire 2 it's a random number, such as
I wouldn't want to do such fragile detection for something important, but since it's just enhancing an error message it should be ok.
Example (from a local test) output with new message: